Skip to content

Conversation

ValGrimm-U3D
Copy link
Contributor

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [y ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [y ] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [y ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [n/a ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Adding View Direction/View Vector doc updated

Testing status

Describe what manual/automated tests were performed for this PR
n/a


Comments to reviewers

Notes for the reviewers you have assigned.

ValGrimm-U3D and others added 4 commits February 19, 2021 08:53
The PR containing the code changes for View Direction / View Vector also included a change to this article. The developer and editorial had reviewed and approved the documentation prepared to release with the code PR, but I was waiting to hear what version I should commit the change to. Due to a miscommunication, I did not have the opportunity to modify this article before the push of the View Direction / View Vector code. Now I am doing so. 
The text I have replaced is:
"Provides access to the mesh vertex or fragment's **View Direction** vector. This is the vector from the vertex or fragment to the camera. The coordinate space of the output value can be selected with the **Space** dropdown parameter.

NOTE: In versions prior to 11.0, the **View Direction** vector was not normalized in the **Universal Render Pipeline**. Version 11.0 changed this behavior, and this vector is now normalized in both the **High-Definition Render Pipeline** and the **Universal Render Pipeline**. To mimic old behavior, you can use the [Position Node](Position-Node.md) in **World** space and subtract the **Position** output of the [Camera Node](Camera-Node.md)."

In the version of the text approved by the dev and editorial, the solution to mimic old behavior is to use the View Vector mode. So I have replaced mention of the position and camera nodes with mention of the View Vector node.
@ValGrimm-U3D ValGrimm-U3D requested a review from a team as a code owner February 23, 2021 16:25
@ValGrimm-U3D ValGrimm-U3D changed the title Shadergraph/documentation/sg doc 2627 Shadergraph/documentation/sg-doc-2627 Feb 23, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!


## Description

This node provides access to the mesh vertex or fragment's **View Direction** vector. It does not normalize any of the values it stores.
Copy link
Contributor

@elizabeth-legros elizabeth-legros Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add "unnormalized", just to help distinguish it from the View Direction node?

@ValGrimm-U3D ValGrimm-U3D merged commit f83e3cd into master Mar 3, 2021
@ValGrimm-U3D ValGrimm-U3D deleted the shadergraph/documentation/sg-doc-2627 branch March 3, 2021 11:00
@sarah-welton sarah-welton restored the shadergraph/documentation/sg-doc-2627 branch August 30, 2021 20:06
@sarah-welton sarah-welton deleted the shadergraph/documentation/sg-doc-2627 branch August 30, 2021 21:08
sarah-welton added a commit that referenced this pull request Sep 1, 2021
* Backport of changes from Val's work on DOC-2627

For ticket DOC-3319/GSG-543

* Added new line at end of file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants