-
Notifications
You must be signed in to change notification settings - Fork 855
Shadergraph/documentation/sg-doc-2627 #3620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The PR containing the code changes for View Direction / View Vector also included a change to this article. The developer and editorial had reviewed and approved the documentation prepared to release with the code PR, but I was waiting to hear what version I should commit the change to. Due to a miscommunication, I did not have the opportunity to modify this article before the push of the View Direction / View Vector code. Now I am doing so. The text I have replaced is: "Provides access to the mesh vertex or fragment's **View Direction** vector. This is the vector from the vertex or fragment to the camera. The coordinate space of the output value can be selected with the **Space** dropdown parameter. NOTE: In versions prior to 11.0, the **View Direction** vector was not normalized in the **Universal Render Pipeline**. Version 11.0 changed this behavior, and this vector is now normalized in both the **High-Definition Render Pipeline** and the **Universal Render Pipeline**. To mimic old behavior, you can use the [Position Node](Position-Node.md) in **World** space and subtract the **Position** output of the [Camera Node](Camera-Node.md)." In the version of the text approved by the dev and editorial, the solution to mimic old behavior is to use the View Vector mode. So I have replaced mention of the position and camera nodes with mention of the View Vector node.
It appears that you made a non-draft PR! |
|
||
## Description | ||
|
||
This node provides access to the mesh vertex or fragment's **View Direction** vector. It does not normalize any of the values it stores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add "unnormalized", just to help distinguish it from the View Direction node?
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*
label. After you backport the PR, the label changes tobackported-*
.CHANGELOG.md
file.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Adding View Direction/View Vector doc updated
Testing status
Describe what manual/automated tests were performed for this PR
n/a
Comments to reviewers
Notes for the reviewers you have assigned.